GHA: setup CMake based build for CI coverage #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lack of CI coverage for CMake based build caused the CMake builds to diverge and regress compared to the SPM builds. Add a second test to ensure that we keep the two build systems in sync.
fiedukow
approved these changes
Mar 7, 2024
| @@ -31,11 +31,49 @@ jobs: | |||
| - uses: dsaltares/fetch-gh-release-asset@a40c8b4a0471f9ab81bdf73a010f74cc51476ad4 # v1.1.1 | |||
| with: | |||
| repo: thebrowsercompany/firebase-cpp-sdk | |||
| version: tags/20230921.0 | |||
| version: tags/20240306.0 | |||
There was a problem hiding this comment.
Hmm, actually, I wonder if we really need the newer firebase images or not 🤔. I think that I was seeing an error that made me think that I needed the latest snapshot for the C++ SDK that we are using. I'm happy to roll this back if you think that is better.
|
Going to go ahead and merge this for now. We can always change the tag back later if desired. This matches what we are currently using in Arc and this change ensures that we get CI coverage to prevent accidental breakages. Now that we can build with CMake here, we can also re-use this definition for building Arc rather than duplicating it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of CI coverage for CMake based build caused the CMake builds to diverge and regress compared to the SPM builds. Add a second test to ensure that we keep the two build systems in sync.