Allow transaction updateBlock to return Error instead of NSError #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately Error > NSError > Error is lossy on Windows.
Given code such as the above, if you convert an instance of
MyErrorType
toNSError
, the result is no longer an instance ofMyErrorType
. This does not happen on Apple platforms.This causes issues when trying to propagate an error generated from
runTransaction
'supdateBlock
to the caller ofrunTransaction
.A solution is to just use
Error
instead ofNSError
in the API.