Expose firestore settings #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches to wrapping the C++ Firestore object with a Swift class so that the Firestore object takes on reference semantics. This allows for code like `Firestore.firestore().settings = ...`
sherryshao
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to wrapping the C++
Firestoreobject with a Swift class so that theFirestoreobject takes on reference semantics. This allows for code likeFirestore.firestore().settings = ...Renames
SettingstoFirestoreSettings, also providing a wrapper. This time using value semantics. But the wrapper helps hide the C++ methods that are named differently than the Obj C API we are trying to emmulate.Expose
isPersistenceEnabledsetting.