Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize implementation of FirebaseAuth methods that return a Future #54

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Modernize implementation of FirebaseAuth methods that return a Future #54

merged 3 commits into from
Mar 25, 2024

Conversation

darinf
Copy link

@darinf darinf commented Mar 22, 2024 •
edited
Loading

Also provides completion variants of async methods to support compatibility with the Firebase Objective C API.

Other changes:

  • Fixes return value of signOut.
  • Removes workaround for SR70253 as it is no longer reproducible / appears to have been resolved.
  • Wraps C++ Auth type in a class to provide reference semantics.

@darinf
Modernize implementation of FirebaseAuth methods that return a Future
a7320ca 
Also provides `completion` variants of async methods to support
compatibility with the Firebase Objective C API.

Fixes return value of `signOut`.
@darinf
try compactMap
c58ffd8
@darinf
back to map
5038cb7
@darinf darinf merged commit cf02bda into main Mar 25, 2024
2 checks passed
@darinf darinf deleted the darin/auth-api-unification branch March 25, 2024 16:35
@fiedukow fiedukow mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiedukow fiedukow fiedukow approved these changes

@sherryshao sherryshao Awaiting requested review from sherryshao

@hyp hyp Awaiting requested review from hyp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darinf @fiedukow