Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirebaseAndroid: introduce the new JNI module for Android support #56

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

compnerd
Copy link
Collaborator

In order to interact with the C++ Firebase SDK, we need to have access to the JVM and the JavaEnvironment. Introduce a JNI layer which allows us to capture this information when loaded. Additionally, register a company.thebrowser.Native.RegisterActivity method to allow us access to the Activity. This is required to be called before the Firebase layer is accessed by the application.

In order to interact with the C++ Firebase SDK, we need to have access
to the JVM and the JavaEnvironment. Introduce a JNI layer which allows
us to capture this information when loaded. Additionally, register a
`company.thebrowser.Native.RegisterActivity` method to allow us access
to the `Activity`. This is required to be called before the Firebase
layer is accessed by the application.
Copy link

@hyp hyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compnerd compnerd merged commit 2d64b87 into thebrowsercompany:main Apr 1, 2024
2 checks passed
@compnerd compnerd deleted the compnerd/jni branch April 1, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants