FirebaseAndroid: fix & remove nullability annotations #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nullability annotations seem to cause warnings due to `-Wnullability-completeness`. Correctly annotating the types as `_Nullable JavaVM * _Nonnull` seems to not work across Swift and C/C++. Rather than try to force this, simply avoid the nullability annotations. Clear up the method registration which was never being invoked due to an early return in the success case.
hyp
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nullability annotations seem to cause warnings due to
-Wnullability-completeness. Correctly annotating the types as_Nullable JavaVM * _Nonnullseems to not work across Swift and C/C++. Rather than try to force this, simply avoid the nullability annotations.Clear up the method registration which was never being invoked due to an early return in the success case.