Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FirebaseFunctions module #63

Merged
merged 18 commits into from
May 13, 2024
Merged

Add FirebaseFunctions module #63

merged 18 commits into from
May 13, 2024

Conversation

darinf
Copy link

@darinf darinf commented May 8, 2024

Changes:

  • Updates workflow to a version of firebase-cpp-sdk that includes functions and storage headers and libs.
  • Adds incomplete support for mapping between Swift Any and C++ firebase::Variant types -- just what is needed by Arc for now.
  • Adds FirebaseFunctionsErrorCode following the pattern for FirestoreErrorCode, et. al.
  • Adds C++ type FunctionsRef as a copyable wrapper for the C++ Functions type, so that it can be exposed to Swift.
  • Adds HTTPSCallable and HTTPSCallableResult wrapper types.
  • Adds basic subset of Functions interface -- just what is needed by Arc for now.

@darinf darinf marked this pull request as ready for review May 11, 2024 04:06
Copy link

@fiedukow fiedukow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but it's hard to tell just from reading the code statically without tests, if there are no minor typos somewhere. It should be safe for existing functionality though, so we can probably merge and test with arc.

Sources/FirebaseCore/Variant+Swift.swift Outdated Show resolved Hide resolved
Copy link

@brianmichel brianmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so nice and clean, thank you Darin!

@darinf darinf merged commit b6bfcdc into main May 13, 2024
2 checks passed
@darinf darinf deleted the darin/firebase-functions branch May 13, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants