-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FirebaseFunctions module #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but it's hard to tell just from reading the code statically without tests, if there are no minor typos somewhere. It should be safe for existing functionality though, so we can probably merge and test with arc
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so nice and clean, thank you Darin!
Changes:
functions
andstorage
headers and libs.Any
and C++firebase::Variant
types -- just what is needed by Arc for now.FirebaseFunctionsErrorCode
following the pattern forFirestoreErrorCode
, et. al.FunctionsRef
as a copyable wrapper for the C++Functions
type, so that it can be exposed to Swift.HTTPSCallable
andHTTPSCallableResult
wrapper types.Functions
interface -- just what is needed by Arc for now.