Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FirebaseFunctions API correctness fixes #64

Merged
merged 2 commits into from
May 14, 2024
Merged

FirebaseFunctions API correctness fixes #64

merged 2 commits into from
May 14, 2024

Conversation

darinf
Copy link

@darinf darinf commented May 14, 2024 •
edited
Loading

Changes:

  • Make HTTPSCallableResult.data public
  • FirebaseFunctionsErrorCode should just be FunctionsErrorCode

@darinf
Make HTTPSCallableResult.data public
f03adaa 
Otherwise it cannot be used. This was intended to be public.
@darinf darinf changed the title Make HTTPSCallableResult.data public FirebaseFunctions API correctness fixes May 14, 2024
@darinf darinf merged commit 0a709cd into main May 14, 2024
2 checks passed
@darinf darinf deleted the darin/fix-httpscallableresult-data-access branch May 14, 2024 04:19
@fiedukow fiedukow mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmichel brianmichel brianmichel approved these changes

@fiedukow fiedukow Awaiting requested review from fiedukow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darinf @brianmichel