Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FirebaseStorage module #65

Merged
merged 10 commits into from
May 15, 2024
Merged

Add FirebaseStorage module #65

merged 10 commits into from
May 15, 2024

Conversation

darinf
Copy link

@darinf darinf commented May 14, 2024 •
edited
Loading

Adds the subset of FirebaseStorage needed by Arc:

  • Storage (partial)
  • StorageReference (partial)
  • StorageMetadata (partial)
  • StorageErrorCode

The implementation of StorageMetadata.customMetadata required some extra thunking through the CxxShims lib.

@darinf darinf marked this pull request as draft May 14, 2024 19:44
@darinf darinf marked this pull request as ready for review May 15, 2024 17:48
brianmichel
brianmichel approved these changes May 15, 2024
View reviewed changes
Copy link

@brianmichel brianmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

Sources/FirebaseStorage/StorageMetadata+Swift.swift Show resolved Hide resolved
fiedukow
fiedukow approved these changes May 15, 2024
View reviewed changes
Copy link

@fiedukow fiedukow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one thing I would consider is adding information about what features in Arc rely on this at this point. If anyone will be doing some archeology on that in the future, it might be useful.

@darinf darinf merged commit e3148a9 into main May 15, 2024
2 checks passed
@darinf darinf deleted the darin/firebase-storage branch May 15, 2024 20:36
@fiedukow fiedukow mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmichel brianmichel brianmichel approved these changes

@fiedukow fiedukow fiedukow approved these changes

@hyp hyp Awaiting requested review from hyp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darinf @brianmichel @fiedukow