[WPP-2267] Avoid HttpsCallableReference copy constructor #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darinf
changed the title
|
Making this a draft pending verification that this actually fixes the issue. |
fiedukow
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately
HttpsCallableReferencedoes not use internal reference counting, and as a result, we need to avoid the copy-constructor forHttpsCallableReference. Otherwise, if Swift creates a copy of the object and deletes that copy, it will result in any pendingCallbeing interrupted or triggering memory corruption in the case thatCallhas not completed. To avoid this and to prevent Swift from seeing the copy constructor, wrap with astd::shared_ptr.