Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: setup CMake based builds on Android #83

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

compnerd
Copy link
Collaborator

@compnerd compnerd commented Jul 9, 2024

This sets up some initial CI support Android to ensure that we do not accidentally regress the Android builds while we are improving swift-firebase.

@compnerd compnerd requested review from brianmichel and hyp July 9, 2024 17:44
@compnerd compnerd force-pushed the android-ci branch 5 times, most recently from 6ac0556 to 061a8e3 Compare July 9, 2024 18:16
Copy link

@brianmichel brianmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me (although I'm sure CI will be the judge), had a few questions.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@compnerd compnerd force-pushed the android-ci branch 3 times, most recently from d2aff18 to 9815ae0 Compare September 11, 2024 16:30
This sets up some initial CI support Android to ensure that we do not
accidentally regress the Android builds while we are improving
swift-firebase.
@compnerd compnerd merged commit 33054a9 into thebrowsercompany:main Sep 11, 2024
4 checks passed
@compnerd compnerd deleted the android-ci branch September 11, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants