Create nuspec for packaging sentry native #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Closed
brianmichel
force-pushed
the
brian_create-nuspec-for-sentry-native
branch
from
a418878
to
70c2728
Compare
|
I ended up not trying to copy the entirety of the Swift sources in since it seems a little complicated to get right this time around. I think it could be a useful approach in the future, but I'd rather try to get this working first. |
|
Should fix WPP-448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a nuspec and update our on-demand CI workflow so that it can actually publish the package to Github.
I've taken the approach of just checking out both this repo and the sentry-native repo into the same workspace to allow them to easily work with one another. This is a tiny bit awkward, but I think it's nice in that we can effectively overlay a nuspec to the upstream repo without the need to fork.
You can see a succesful run of the workflow here #3 and the published package here https://github.com/thebrowsercompany/swift-sentry/pkgs/nuget/company.thebrowser.sentry-native.crashpad