Fix macOS building from Xcode #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianmichel
force-pushed
the
brian/fix-xcode-compilation
branch
from
5770a7e
to
b627def
Compare
brianmichel
force-pushed
the
brian/fix-xcode-compilation
branch
from
b627def
to
877464e
Compare
compnerd
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building on macOS using the command line tools would build this project fine, however when switching to Xcode you would encounter errors that looked like this:
This seems to be because the
sentrymodule which is only a single header and module map will fail to create a.ofile since it has no implementation files. I've added adummy.cwith a comment on why it exists (since it has no code) and this seems to resolve the issue.I also took this opportunity to add a call to run the macOS runloop in the example so you can see the Sentry output, as well as take a first stab at basic CI to ensure we're building macOS and Windows.(Note: I realized that without #6 being fixed, there isn't an easy way to get the vendored assets, so CI will have to wait a little longer)
How To Test
swift buildon macOS after setting up your vendored sources on this branch