Fixed memory leaks #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Oh, tested on Linux 4.0.4-202.fc21.x86_64 and Fedora 21. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix bug #3 ; I couldn't reproduce the reported crashes, but valgrind found two issues which I think might be fixed by that patch. It simply adds two free()-statements.
Old valgrind results here: https://gist.github.com/yalla/72b740a73e13d15cef32
New valgrind results here: https://gist.github.com/yalla/bcc25378c076d06d9bdb
Resulting PCAP-files are binary-equal, for testing I used this GTP-U file from cloudshark: http://cloudshark.org/captures/374cf36574b6