Fix: PublicRuntimeEnvironment not available in docker #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkyeremeh
commented
Dec 7, 2022
| @@ -1,4 +1,4 @@ | |||
| FROM node:12-alpine | |||
| FROM node:lts-alpine | |||
Comment on lines
+15
to
+17
| # Remove Env variables from container before building | ||
| RUN rm -rf .env | ||
|
|
There was a problem hiding this comment.
Removing .env from the docker image during build process. This is to prevent local .env during development from being used for publicRuntimeConfig
| const app = nextApp({ | ||
| dir: "./client", | ||
| dev: env.isDev, | ||
| conf: { publicRuntimeConfig } |
There was a problem hiding this comment.
Add publicRuntimeConfig to nextApp from express
dkyeremeh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #656
This PR fixes issues arising from
publicRuntimeConfignot being loaded when using docker.This issue occurs because the values of
publicRuntimeConfigare generated during the build process.This prevents the values supplied by .env files later on from taking effects.
The PR fixes this issue by supplying
publicRuntimeConfigto the nextApp when it is loaded byserver/server.js