Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate apparent speaker width and use to determine heading tolerance #163

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Calculate apparent speaker width and use to determine heading tolerance #163

merged 1 commit into from
Mar 10, 2024

Conversation

james-ward
Copy link
Contributor

No description provided.

@james-ward james-ward requested a review from mlists March 4, 2024 13:45
mlists
mlists approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@mlists mlists left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it will work, I am still not fully convinced that a margin is a better magic number than just tuning the tolerance directly. I would like to see how this performs in testing before we decide if this is the way to go.

@SebZanardo SebZanardo force-pushed the james/speaker-width-tolerance branch from c341add to c05516a Compare March 10, 2024 03:54
@SebZanardo SebZanardo merged commit 80d6806 into main Mar 10, 2024
6 checks passed
@SebZanardo SebZanardo deleted the james/speaker-width-tolerance branch March 10, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlists mlists mlists approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james-ward @mlists @SebZanardo