Added base shooter class #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outsidermm
reviewed
Jan 11, 2024
| """Causes the shooter motor to spin""" | ||
| self.deployed = True | ||
|
|
||
| def is_ready(self): |
There was a problem hiding this comment.
I think we should make these so-called "feedback" functions with feedback decorators from magicbot
e.g.
@feedback
def is_ready(self) -> bool
|
|
||
| def is_ready(self): | ||
| return True | ||
|
|
There was a problem hiding this comment.
I think it's safe to say we need more feedback methods.
I'm thinking of two feedback methods:
- actual_velocity
- flywheel error
outsidermm
force-pushed
the
ShooterComponent
branch
from
dfd9958
to
5efe6c5
Compare
fotnitfpro000
force-pushed
the
ShooterComponent
branch
from
5efe6c5
to
b19a013
Compare
auscompgeek
reviewed
Jan 14, 2024
auscompgeek
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the base for the shooter class