-
Notifications
You must be signed in to change notification settings - Fork 0
Add hood control #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alexander-Mironenko
wants to merge
11
commits into
main
Choose a base branch
from
turret_hood
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+71
−6
Open
Add hood control #64
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d4b2e6f
Add initial hood interface
Alexander-Mironenko 3e5b034
add hood motor and encoder config
9758cf9
renamed hood articulate functions
5d7e368
correctly configure the hood encoder to be directly wired into the ho…
1fd01a7
configure encoder and write functions to operate the hood
e8aca10
fix encoder position conversion factor and complete some unfinished code
714f383
fix tunable injection error
4cdf38a
update gear ratios
087ef84
fixed some logic and config errors (kindly spotted by greptile)
6d73afb
fix another error
edd15b8
tune encoder offsets
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,6 +45,8 @@ class SparkId(enum.IntEnum): | |
|
|
||
| INTAKE = 11 | ||
|
|
||
| HOOD = 10 | ||
|
|
||
|
|
||
| @enum.unique | ||
| class DioChannel(enum.IntEnum): | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're calling this "encoder rotations per hood degree", but this is (in a very roundabout way) multiplying by 360°. The dimensional analysis maths isn't mathsing here.
Also is there a reason we're working in degrees here?