Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable reverse proxy by default #958

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Aug 14, 2024

No description provided.

@ehelms ehelms force-pushed the disable-reverse-proxy-default branch 2 times, most recently from b595183 to d400a14 Compare August 14, 2024 13:17
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the migration itself, just some comments on the tests.

spec/migration_spec.rb Outdated Show resolved Hide resolved
spec/migration_spec.rb Outdated Show resolved Hide resolved
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not suggesting them earlier. It looks ok, but we can improve the descriptions a bit.

ehelms and others added 2 commits August 14, 2024 10:16
…spec.rb

Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
…spec.rb

Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
@ehelms ehelms merged commit ae66de5 into theforeman:develop Aug 14, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants