Fixes #36999 - Drop libvirt CPU model option for VM creation #9963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
commented
Dec 19, 2023
Comment on lines
-14
to
-21
| def cpu_mode | ||
| attributes[:cpu][:mode] | ||
| end | ||
|
|
||
| def cpu_mode=(cpumode) | ||
| attributes[:cpu][:mode] = (cpumode == 'default') ? nil : cpumode | ||
| end | ||
|
|
There was a problem hiding this comment.
It may be that this was also how it was previously set for the API, but I'm not sure it was ever exposed properly.
Since fog-libvirt 0.12.0 the default CPU model was some abstract type with a low compatibility level. Since 0.12.0 it defaults to CPU passthrough, as recommended by qemu if live migration is not required (https://www.qemu.org/docs/master/system/qemu-cpu-models.html). That's not something we support today, so it should be safe to drop the CPU model selection.
ekohl
force-pushed
the
36999-drop-libvirt-cpu-model
branch
from
f96ddfb
to
8097b38
Compare
|
LGTM, could you please also update https://github.com/theforeman/hammer-cli-foreman/blob/master/doc/host_create.md. Given this changes the API, it should probably be mentioned in the release notes. |
That states:
Which is ancient. Anyway, theforeman/hammer-cli-foreman#629. |
ehelms
approved these changes
Jul 12, 2024
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since fog-libvirt 0.12.0 the default CPU model was some abstract type with a low compatibility level. Since 0.12.0 it defaults to CPU passthrough, as recommended by qemu if live migration is not required (https://www.qemu.org/docs/master/system/qemu-cpu-models.html). That's not something we support today, so it should be safe to drop the CPU model selection.
RFC open for this: https://community.theforeman.org/t/drop-cpu-type-option-from-libvirt-compute-resource-provisioning/36267