Fix Rails/FindEach cop

theforeman · Jan 10, 2024 · 90b9920 · 90b9920
1 parent 96f1eae
commit 90b9920
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -31,3 +31,6 @@ Minitest/EmptyLineBeforeAssertionMethods:
 
 Minitest/AssertPredicate:
   Enabled: true
+
+Rails/FindEach:
+  Enabled: true
diff --git a/app/controllers/foreman_salt/state_importer.rb b/app/controllers/foreman_salt/state_importer.rb
@@ -63,11 +63,11 @@ def remove_from_environment(states, environment)
     end
 
     def clean_orphans
-      SaltModule.all.each do |state|
+      SaltModule.all.find_each do |state|
         state.destroy if state.salt_environments.empty?
       end
 
-      SaltEnvironment.all.each do |environment|
+      SaltEnvironment.all.find_each do |environment|
         environment.destroy if environment.salt_modules.empty?
       end
     end

diff --git a/db/migrate/20150220122707_fix_incorrect_report_metrics.rb b/db/migrate/20150220122707_fix_incorrect_report_metrics.rb
@@ -1,6 +1,6 @@
 class FixIncorrectReportMetrics < ActiveRecord::Migration[4.2]
   def up
-    Report.all.each do |report|
+    Report.all.find_each do |report|
       next unless report.metrics && report.metrics['time']
 
       metrics = report.metrics.dup

diff --git a/db/migrate/20150411003302_add_environments_to_modules.rb b/db/migrate/20150411003302_add_environments_to_modules.rb
@@ -6,7 +6,7 @@ def up
     end
 
     environments = ForemanSalt::SaltEnvironment.all
-    ForemanSalt::SaltModule.all.each do |state|
+    ForemanSalt::SaltModule.all.find_each do |state|
       state.salt_environments << environments
     end
   end