Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rubocop rake task #193

Merged
merged 2 commits into from
Jan 18, 2024
+9 −3
Merged

Add Rubocop rake task #193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a98c174
Remove APP_RAKEFILE assignment
archanaserver Jan 16, 2024
7d4dacf
Add RuboCop Rake task
archanaserver Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ begin
rescue LoadError
puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
end

begin
require 'rdoc/task'
rescue LoadError
Expand All @@ -20,9 +21,6 @@ RDoc::Task.new(:rdoc) do |rdoc|
rdoc.rdoc_files.include('lib/**/*.rb')
end

APP_RAKEFILE = File.expand_path('test/dummy/Rakefile', __dir__)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came across https://guides.rubyonrails.org/engines.html#testing-an-engine and that's where it comes from.

load 'rails/tasks/engine.rake'

Bundler::GemHelper.install_tasks

require 'rake/testtask'
Expand All @@ -34,4 +32,12 @@ Rake::TestTask.new(:test) do |t|
t.verbose = false
end

begin
require 'rubocop/rake_task'
rescue LoadError
# Test group disabled
else
RuboCop::RakeTask.new
end

task default: :test
Loading