Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for dashes in saltenv names (e.g. when importing git-branch-backed salt environments like
jira-12345-feature-xyz
). (as discussed here: https://community.theforeman.org/t/salt-state-import-fails-on-3-10-el9-due-to-salt-state-names-being-considered-invalid-for-activerecord/37592/11)Such environment names are already supported by salt itself, so not being able to use them from foreman is a huge inconvenience.
(Edit: salt even supports forward slashes in environment names, like in git prefixes "feature/xy" or "pr/abc-def", but that leads to other problems, namely that foreman tries to treat the env-name as an URL part, when syncing, which fails due to the unescaped slash... so not included here, but technically possible)
Please also backport this change to Foreman 3.10.