Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dashes in saltenv names #202

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

BigBadBassMan
Copy link
Contributor

@BigBadBassMan BigBadBassMan commented Apr 10, 2024

This allows for dashes in saltenv names (e.g. when importing git-branch-backed salt environments like jira-12345-feature-xyz). (as discussed here: https://community.theforeman.org/t/salt-state-import-fails-on-3-10-el9-due-to-salt-state-names-being-considered-invalid-for-activerecord/37592/11)

Such environment names are already supported by salt itself, so not being able to use them from foreman is a huge inconvenience.

(Edit: salt even supports forward slashes in environment names, like in git prefixes "feature/xy" or "pr/abc-def", but that leads to other problems, namely that foreman tries to treat the env-name as an URL part, when syncing, which fails due to the unescaped slash... so not included here, but technically possible)

Please also backport this change to Foreman 3.10.

Copy link
Contributor

@nadjaheitmann nadjaheitmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nadjaheitmann nadjaheitmann merged commit 5b0c8b5 into theforeman:master Apr 12, 2024
20 checks passed
@nadjaheitmann
Copy link
Contributor

Thanks @BigBadBassMan

@BigBadBassMan BigBadBassMan deleted the patch-1 branch April 15, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants