Add clickthrough to trends

theforeman · Aug 16, 2021 · ce238ef · ce238ef
1 parent 00e36c9
commit ce238ef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/app/helpers/foreman_statistics/trends_helper.rb b/app/helpers/foreman_statistics/trends_helper.rb
@@ -39,11 +39,7 @@ def trend_title(trend)
     def trend_chart_data(trend, from = Setting[:max_trend])
       data = {}
       names = {}
-      paths = {}
-      trend.values.preload(:trendable).each do |value|
-        names[value.id] = CGI.escapeHTML(value.to_label)
-        paths[value.id] = trend_path(id: value)
-      end
+      trend.values.preload(:trendable).each { |value| names[value.id] = CGI.escapeHTML(value.to_label) }
       trend.values.preload(:trend_counters).joins(:trend_counters)
            .where(['trend_counters.interval_end > ? or trend_counters.interval_end is null', from])
            .reorder('trend_counters.interval_start')

diff --git a/app/views/foreman_statistics/trends/show.html.erb b/app/views/foreman_statistics/trends/show.html.erb
@@ -5,7 +5,7 @@
     <div class="stats-well trends-chart">
       <h4 class="ca"><%= "#{trend_title(@trend)}" %></h4>
       <h6 class="ca"><%= n_("last %s day", "last %s days", trends_range) % trends_range %></h6>
-      <%= react_component('AreaChart', yAxisLabel: _('Number of Hosts'), data: trend_chart_data(@trend, trends_range.days.ago)) %>
+      <%= react_component('AreaChart', yAxisLabel: _('Number of Hosts'), data: trend_chart_data(@trend, trends_range.days.ago), searchUrl: trend_path(id: '~VAL~')) %>
     </div>
   </div>
 </div>