Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reusable GitHub Actions for testing #55

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Use reusable GitHub Actions for testing #55

merged 1 commit into from
Mar 5, 2024

Conversation

nofaralfasi
Copy link
Contributor

No description provided.

stejskalleos
stejskalleos reviewed Feb 22, 2024
View reviewed changes
.rubocop_todo.yml Outdated Show resolved Hide resolved
stejskalleos
stejskalleos requested changes Feb 22, 2024
View reviewed changes
.rubocop.yml Outdated Show resolved Hide resolved
.rubocop.yml Outdated Show resolved Hide resolved
hammer_cli_foreman_discovery.gemspec Outdated Show resolved Hide resolved
ekohl
ekohl reviewed Feb 22, 2024
View reviewed changes
Rakefile Outdated Show resolved Hide resolved
@nofaralfasi
Copy link
Contributor Author

@ShimShtein can you please review?

ekohl
ekohl reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd disable the cop that enforces single quotes. It's essentially rewriting the whole codebase and it's debatable if adds any value. In the past there was a performance benefit but that's no longer true.

.rubocop.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally a fan of enabling all cops:

  AllCops:
    NewCops: enable

@ekohl ekohl mentioned this pull request Feb 27, 2024
Merged
@nofaralfasi nofaralfasi changed the title Use reusable GitHub Actions for testing [WIP] Use reusable GitHub Actions for testing Feb 28, 2024
@nofaralfasi nofaralfasi marked this pull request as draft February 28, 2024 09:57
@nofaralfasi
Copy link
Contributor Author

I will continue this work after theforeman/hammer-cli-foreman-ansible#27 and theforeman/hammer-cli-foreman-ansible#29 are merged.

@nofaralfasi nofaralfasi changed the title [WIP] Use reusable GitHub Actions for testing Use reusable GitHub Actions for testing Mar 3, 2024
@nofaralfasi nofaralfasi marked this pull request as ready for review March 3, 2024 15:21
@nofaralfasi
Copy link
Contributor Author

Created #57 for adding Rubocop.

ekohl
ekohl reviewed Mar 3, 2024
View reviewed changes
test/unit/discovery_rules_test.rb
@@ -9,39 +9,39 @@

include CommandTestHelper

context "ListCommand" do
describe "ListCommand" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a RuboCop rule, or is it related to updating a dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the dependency. Apparently, you cannot have a context inside a describe block.

@stejskalleos stejskalleos merged commit 8e7529c into theforeman:master Mar 5, 2024
6 of 7 checks passed
@stejskalleos
Copy link
Contributor

Thanks everyone!

@nofaralfasi nofaralfasi mentioned this pull request Mar 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archanaserver archanaserver archanaserver left review comments

@stejskalleos stejskalleos stejskalleos requested changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nofaralfasi @stejskalleos @ekohl @archanaserver