Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36954 - add cache status to ping output #622

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Fixes #36954 - add cache status to ping output #622

merged 2 commits into from
Nov 29, 2023

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Nov 29, 2023

No description provided.

field :cache, _('cache'), Fields::Label do
field :servers, _('servers'), Fields::Collection do
field :status, _('Status')
field :duration_ms, _('Server Response')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "server response time", or should we add some translation like we have in

data['results']['foreman']['database']['duration_ms'] = _('Duration: %sms') % duration

Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evgeni, I'm going to release new major version today and wanted to include this change as well, thus I've pushed additional commit just to make thing more consistent and at the same time answering your question :)

@ofedoren ofedoren merged commit 0040042 into master Nov 29, 2023
9 checks passed
@evgeni evgeni deleted the redis branch November 29, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants