Skip to content

Add python linter job #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

dosas
Copy link
Contributor

@dosas dosas commented Dec 4, 2024

and fix warnings

@bastian-src I hope the added .pylintrc does not cause problems in foreman or ruby packaging?

Copy link

@bastian-src bastian-src left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @dosas!!
I think its a great idea to lint our custom Python Salt modules.
Could you please split your changes into two commits (adding GHA, adding Python fixes + pylintrc)?

@evgeni do you have comments too?

@bastian-src
Copy link

I assume there are not further comments :) thanks @dosas for the PR and @evgeni for commenting!

@bastian-src bastian-src merged commit a557d2d into theforeman:master Dec 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants