update invoice xml test + Refact params

thegreenter · Jul 27, 2017 · ae3d8f6 · ae3d8f6
1 parent c8409ef
commit ae3d8f6
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 20 deletions.
diff --git a/src/Greenter/FeFactory.php b/src/Greenter/FeFactory.php
@@ -144,15 +144,7 @@ public function setCompany(Company $company)
      */
     public function setParameters($params)
     {
-        $ws = $params['ws'];
-        $this->sender->setCredentials($ws['user'], $ws['pass']);
-        if (isset($ws['service'])) {
-            $this->sender->setService($ws['service']);
-        }
-
-        if (isset($ws['wsdl'])) {
-            $this->sender->setUrlWsdl($ws['wsdl']);
-        }
+        $this->setWsParams($params['ws']);
 
         if (isset($params['xml'])) {
             $this->builder->setParameters($params['xml']);
@@ -165,6 +157,20 @@ public function setParameters($params)
         }
     }
 
+    /**
+     * @param array $ws
+     */
+    private function setWsParams($ws)
+    {
+        $this->sender->setCredentials($ws['user'], $ws['pass']);
+        if (isset($ws['service'])) {
+            $this->sender->setService($ws['service']);
+        }
+        if (isset($ws['wsdl'])) {
+            $this->sender->setUrlWsdl($ws['wsdl']);
+        }
+    }
+
     /**
      * @param string $xml
      * @param string $filename

diff --git a/tests/Greenter/Resources/invoice.xml b/tests/Greenter/Resources/invoice.xml
@@ -56,17 +56,6 @@
             <cac:PartyName>
                 <cbc:Name>EMPRESA</cbc:Name>
             </cac:PartyName>
-            <cac:AgentParty>
-                <cac:PartyIdentification>
-                    <cbc:ID>20000000001</cbc:ID>
-                </cac:PartyIdentification>
-                <cac:PartyName>
-                    <cbc:Name>EMPRESA SAC</cbc:Name>
-                </cac:PartyName>
-                <cac:PartyLegalEntity>
-                    <cbc:RegistrationName>EMPRESA SAC</cbc:RegistrationName>
-                </cac:PartyLegalEntity>
-            </cac:AgentParty>
         </cac:SignatoryParty>
         <cac:DigitalSignatureAttachment>
             <cac:ExternalReference>