Introduce use of app-specific exceptions #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve error handling and logging in the
carbon_txt
CLI application. The most important changes involve replacingsys.exit
calls withtyper.Exit
for better integration with Typer, enhancing exception handling, and adding new tests for missing files.Error Handling Improvements:
sys.exit
calls withtyper.Exit
in various functions for better integration with Typer. [1] [2] [3] [4] [5] [6]validate_file
to catch specific exceptions (FileNotFoundError
,UnreachableCarbonTxtFile
,NotParseableTOML
) and log appropriate messages.Logging Enhancements:
validate_file
to log the discovery and parsing ofcarbon.txt
files.Exception Handling Enhancements:
UnreachableCarbonTxtFile
,NotParseableTOML
) inexceptions.py
to handle specific error cases.finders.py
andparsers_toml.py
to use the new exceptions for better error reporting. [1] [2] [3] [4]Testing Improvements:
test_cli.py
to check the behavior when acarbon.txt
file is missing.