Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adopt pydot #40

Merged
merged 67 commits into from
Dec 14, 2024
Merged

Re-adopt pydot #40

merged 67 commits into from
Dec 14, 2024

Conversation

chrizzFTD
Copy link
Collaborator

@chrizzFTD chrizzFTD commented Aug 19, 2024

Needs networkx/networkx#7606 to be released.

Thanks to networkx/networkx#7204 pydot is supported again by networkx.

If locked in python-3.9, the last supported combo with this update is:

  • networkx==2.8.3 (or older)
  • pydot-3.0.1 (or newer)

Additions

  • Attribute context menu items in USDView for clearing and blocking values
  • Extend CI to test USD-21.11 + Python-3.9
  • Support Maya-2025 (which uses PySide6)
  • Test data for faster tests

Changes

@chrizzFTD chrizzFTD force-pushed the feature/re-adopt_pydot branch from 97c61fc to 7349bff Compare September 3, 2024 12:07
@chrizzFTD chrizzFTD changed the base branch from feature/graphview_fix_edge_spline_shift to develop September 3, 2024 12:09
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 98.63388% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.73%. Comparing base (2c09127) to head (b7c3fa0).

Files with missing lines Patch % Lines
grill/views/_graph.py 95.23% 3 Missing ⚠️
grill/views/_qt.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #40      +/-   ##
===========================================
- Coverage    92.83%   92.73%   -0.11%     
===========================================
  Files           17       17              
  Lines         3826     3718     -108     
===========================================
- Hits          3552     3448     -104     
+ Misses         274      270       -4     
Files with missing lines Coverage Δ
grill/cook/__init__.py 100.00% <100.00%> (+0.35%) ⬆️
grill/usd/__init__.py 100.00% <100.00%> (ø)
grill/views/_core.py 91.88% <ø> (-0.15%) ⬇️
grill/views/description.py 92.55% <100.00%> (-0.55%) ⬇️
tests/test_cook.py 100.00% <100.00%> (ø)
tests/test_usd.py 100.00% <ø> (ø)
tests/test_views.py 100.00% <100.00%> (ø)
grill/views/_qt.py 73.68% <60.00%> (-6.32%) ⬇️
grill/views/_graph.py 78.26% <95.23%> (+1.47%) ⬆️

... and 1 file with indirect coverage changes

@chrizzFTD chrizzFTD force-pushed the feature/re-adopt_pydot branch from 7349bff to aeb55d7 Compare September 3, 2024 12:34
@chrizzFTD chrizzFTD force-pushed the feature/re-adopt_pydot branch from aeb55d7 to 0237be4 Compare September 14, 2024 06:27
@chrizzFTD chrizzFTD force-pushed the feature/re-adopt_pydot branch from 03b6d99 to ab8db52 Compare October 26, 2024 00:18
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
…y resolver context)

Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
asset_identifier is public

Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
…ith cpython?

Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
@chrizzFTD chrizzFTD merged commit 3e519a5 into develop Dec 14, 2024
4 checks passed
@chrizzFTD chrizzFTD deleted the feature/re-adopt_pydot branch December 14, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant