fix the missing_values_barplot errors #963
Merged
+28
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n local hatch env
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
sueoglu
changed the title
Zethson
reviewed
Oct 15, 2025
…olerance changed from 5 to 6
for more information, see https://pre-commit.ci
Zethson
reviewed
Oct 16, 2025
tests/plot/test_missingno_pl_api.py
Outdated
| @pytest.mark.parametrize("layer", [None, "layer_2"]) | ||
| def test_missing_values_barplot(mimic_2, check_same_image, layer): | ||
| def test_missing_values_barplot(mimic_2, check_same_image, layer, clean_up_plots): | ||
| plt.close("all") |
There was a problem hiding this comment.
We shouldn't need this here anymore, right?
There was a problem hiding this comment.
let me try without it if it still passes I'll remove it
tests/plot/test_scanpy_pl_api.py
Outdated
|
|
||
| def test_pca_overview(mimic_2_sample_serv_unit_day_icu, check_same_image): | ||
| def test_pca_overview(mimic_2_sample_serv_unit_day_icu, check_same_image, clean_up_plots): | ||
| plt.close("all") |
added 5 commits
October 16, 2025 12:41
…nd so trying to push again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #961