[Rebase] Add s3 canned ACL support #779
Open
+76
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
rzvoncek
force-pushed
the
radovan/rebase-189
branch
2 times, most recently
from
f955568
to
38d1307
Compare
rzvoncek
force-pushed
the
radovan/rebase-189
branch
from
38d1307
to
cf95e62
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rebase of #189 on top of the current main.
The storage implementation has changed a lot since 189 was opened, so I had to rework things a bit.
I've tried adding ITs for the ACLs, but it's not easy. To begin with, we'd need a ACL-enabled bucket, which I'm hesitant to create.
Superseeds #189.
We don't have an issue.