Propagate Medusa process exit code in k8s docker-entrypoint #806
+11
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #805
Prior to this change, if the Medusa process exits with a non-zero exit code for some reason, the Medusa container will be stuck forever because of the
while true
loop.With this fix, the while loop will be interrupted if the Medusa process exits, and the container will exit with the same code as the Medusa process exit code.
To validate this change, I've manually tested the following scenarios:
/etc/medusa.ini
-> the container should exit with a non-zero code./etc/medusa.ini
-> the container should run as expected./etc/medusa.ini
while the container is running -> the container should exit with a zero code.sys.exit(42)
inserver.py
to mock a production issue -> the container should exit with the status code 42.