Skip to content

feat(mention): remove mention* props#369

Open
tx0c wants to merge 1 commit intodevelopfrom
bump/pr-195-remove-mention-props
Open

feat(mention): remove mention* props#369
tx0c wants to merge 1 commit intodevelopfrom
bump/pr-195-remove-mention-props

Conversation

@tx0c
Copy link
Copy Markdown
Contributor

@tx0c tx0c commented Oct 6, 2021

this is picked up from PR #195 rebased to latest develop

removing the mentionInstance can avoid the ref change caused ReactQuill always initialize Quill twice, help resolve part thematters/matters-web#2114

References #192

this is picked up from PR #195 rebased to latest develop

but why #192 relevant?
@tx0c tx0c requested a review from a team as a code owner October 6, 2021 03:02
Copy link
Copy Markdown
Contributor

@guoliu guoliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👊💪🌱

@robertu7 robertu7 self-requested a review October 6, 2021 05:12
Copy link
Copy Markdown
Contributor

@robertu7 robertu7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new implementation of mention feature needs to be added to matters-web first?

@tx0c
Copy link
Copy Markdown
Contributor Author

tx0c commented Oct 6, 2021

💥 💥 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Editor] - Code block eats up lines if it's added in the beginning of article content

3 participants