Fix/define type for json responses #1113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
paghar
force-pushed
the
fix/define-type-for-json-responses
branch
from
c149b8b to
b4d091a
Compare
|
Hi👋🏻@rluders |
| @@ -1,4 +1,8 @@ | |||
| export const safeResJson = (res: Response) => { | |||
| export interface JsonResponseType { | |||
There was a problem hiding this comment.
thing is, we don't always know if the response is a plain Record, basically it can be anything.
I left it any because I needed to strongly type the responses of all API calls and I just didn't feel like doing it, derp.
Normally it should be typed as Promise<unknown> and unknown also extends T, which comes from the place where the function is fired.
@rluders what do u think about this? should we just merge the result to be "fale always" a Record?
|
deprecated by #1118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize the changes made and the motivation behind them.
Reference related issues using
#followed by the issue number.If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.