Feat/list component #1122
Feat/list component #1122
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
hi @rluders, |
paghar
force-pushed
the
feat/list-component
branch
from
492fed0 to
681d891
Compare
paghar
force-pushed
the
feat/list-component
branch
2 times, most recently
from
b4d7bf4 to
b2dbcbe
Compare
|
@SutuSebastian fixed right now :) |
| return ( | ||
| <Component | ||
| className={twMerge( | ||
| theme.root.ordered[props.ordered ? 'on' : 'off'], |
There was a problem hiding this comment.
I think it would be a good idea for the future to start using https://cva.style/docs for the variants, instead of handling it differently for each component.
|
some prettier must be ran so build can pass |
paghar
force-pushed
the
feat/list-component
branch
from
b2dbcbe to
8478f3e
Compare
|
@SutuSebastian Thanks for your information. |
added component files + props, tests, stories, examples fix themesberg#1017
paghar
force-pushed
the
feat/list-component
branch
from
8478f3e to
01065d4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
- Coverage 99.54% 93.58% -5.97%
==========================================
Files 163 213 +50
Lines 6621 9026 +2405
Branches 401 481 +80
==========================================
+ Hits 6591 8447 +1856
- Misses 30 579 +549 ☔ View full report in Codecov by Sentry. |
Summarize the changes made and the motivation behind them.
Reference related issues using
#followed by the issue number.If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.