Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(progress): add missing colors for Progress component #1129

Merged
merged 1 commit into from
Nov 12, 2023
Merged

feat(progress): add missing colors for Progress component #1129

merged 1 commit into from
Nov 12, 2023

Conversation

MateoWartelle
Copy link
Contributor

Summarize the changes made and the motivation behind them.

  • Added missing colors to Progress Bar
  • Blue != Cyan

Reference related issues using # followed by the issue number.

If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.

Copy link

vercel bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 1:46pm

@MateoWartelle MateoWartelle marked this pull request as draft November 12, 2023 13:41
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7461173) 99.54% compared to head (42f9d05) 98.72%.
Report is 144 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
- Coverage   99.54%   98.72%   -0.83%     
==========================================
  Files         163      173      +10     
  Lines        6621     7969    +1348     
  Branches      401      475      +74     
==========================================
+ Hits         6591     7867    +1276     
- Misses         30      102      +72     

see 153 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateoWartelle MateoWartelle marked this pull request as ready for review November 12, 2023 13:49
Copy link
Collaborator

@SutuSebastian SutuSebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rluders rluders merged commit f8853af into themesberg:main Nov 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants