-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(checkbox): standalone page for checkbox documentation #1130
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1130 +/- ##
==========================================
- Coverage 99.54% 93.60% -5.95%
==========================================
Files 163 213 +50
Lines 6621 9049 +2428
Branches 401 483 +82
==========================================
+ Hits 6591 8470 +1879
- Misses 30 579 +549 ☔ View full report in Codecov by Sentry. |
weird.. I can't tell what is wrong with the preview. The build passes locally.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is nice!
This passes locally for u probably because u renamed the file afterwards from Build fails due to:
I left comments where it should be fixed. |
ahhh thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the disabled state doesn't look like https://flowbite.com/docs/forms/checkbox/#disabled-state
ohh I see Label was not disabled. |
@MateoWartelle @SutuSebastian I think that we are good to merge this one, right? Just need to rebase. |
There's still this issue that hasn't been resolved: Screen.Recording.2023-11-14.at.23.59.44.movand it applies to both |
I notice that when the checkbox is marked by default to be |
Giving it the prop Switching |
Some minor differences:
Core
|
Summarize the changes made and the motivation behind them.
To create separate pages for /forms/* documentations to match flowbite.
I had tried this previously but the branch was too far gone to continue (merge conflicts).
Reference related issues using
#
followed by the issue number.If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.