-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tooltip): adds tooltip support for restMs and delay properties #1200
base: main
Are you sure you want to change the base?
feat(tooltip): adds tooltip support for restMs and delay properties #1200
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1200 +/- ##
==========================================
- Coverage 99.54% 97.37% -2.18%
==========================================
Files 163 214 +51
Lines 6621 9093 +2472
Branches 401 530 +129
==========================================
+ Hits 6591 8854 +2263
- Misses 30 239 +209 ☔ View full report in Codecov by Sentry. |
73b3dba
to
76132ab
Compare
I understand the practical appeal, but this functionality isn't available in the upstream library at flowbite.com, so I'm not sure if we should add it here. @zoltanszogyenyi I defer to you on this one - it seems like this would be a useful feature, and it's also pretty difficult to create a wrapper of our component to achieve this. You would probably be forced to patch flowbite-react to do so. |
It looks like the upstream has support for |
Nice one! It only needs re-build since we now have new monorepo structure (see #1264). If u feel like u don't have the time, I can take it from here, just let me know! 🤝 |
@SutuSebastian I doubt I'll have time for this in the near-term. Feel free to pick it up if you'd like. |
implements #589
This change adds support for floating-ui's
useHover
restMs
anddelay
props to theTooltip
component to enable delayed opening/closing of tooltips.