Feature/carousel active slide #1214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ider item 'activeSlide' prop is zero-based position. Default value is '0'. Negative values are converted to '0'. If value is greater than number of items, default item will be the last one. fix themesberg#1094
Covering negative value and value greater than slider items
Provided example with activeSlide prop
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
==========================================
- Coverage 99.54% 97.36% -2.18%
==========================================
Files 163 214 +51
Lines 6621 9085 +2464
Branches 401 532 +131
==========================================
+ Hits 6591 8846 +2255
- Misses 30 239 +209 ☔ View full report in Codecov by Sentry. |
|
Hi. I'm not one of the maintainer of this repository but thanks for implementing this very useful update. I went over the PR and It LGTM. Only a minor comment for :
In the case of an invalid index, I prefer keeping the current active item as it makes debugging issues easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'activeSlide' prop with tests and docs. I considered the following facts:
Validate 'activeSlide' prop:
If negative value, default slider item is set to '0'. If value is greater than carousel childs, default slider item is set to the last one. If no carousel childs, exit useEffect.
Default value:
If no 'activeSlide' prop provided, default value is set to 0.
Update 'activeItem' State
'activeItem' is set to 'activeSlide' when the component mounts.
Fixes #1094