-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(alert): make props reactive #320
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for sensational-seahorse-8635f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/components/FwbAlert/FwbAlert.vue (3 hunks)
Additional comments not posted (3)
src/components/FwbAlert/FwbAlert.vue (3)
61-61
: LGTM!The import statement has been updated correctly to include
computed
from Vue, which is used in the component.
115-115
: LGTM!The
closeBtnClasses
computed property has been implemented correctly. It uses thetwMerge
function to merge the default close button classes with the type-specific close button classes, allowing the classes to update automatically based on thetype
prop. This improves the component's reactivity.
130-137
: LGTM!The
wrapperClasses
computed property has been implemented correctly. It uses thetwMerge
function to merge various classes based on the component's props, allowing the classes to update automatically. This improves the component's reactivity.
Some of the props for the alert component are only parsed on init so any changes aren't reflect unless the component is rerendered. Switched those bits to use computed refs so they do listen for prop changes
Summary by CodeRabbit
FwbAlert
component with dynamic class name handling for improved responsiveness based on props.