Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation restricts
ValidationBuilder
to be only used in theTextFormField
s or wherever the value is in a string. There are some cases where we would need to validate values other thanString
likeDropdownFormField
or any customFormField
.Consider this example
DatePickerFormField
is a custom widget I made usingFormField
. the validator has this signature.I can not use the current
ValidationBuilder
in this case. To solve this I've added generics support to the originalValidationBuilder
class and rename it toGenericValidationBuilder
. To avoid breaking the old code I've added a typedef with the original class name.Please review the PR.