Skip to content

Commit

Permalink
Removing check for bulbs_ias feature switch
Browse files Browse the repository at this point in the history
  • Loading branch information
BriceShatzer authored Jul 11, 2018
2 parents a419786 + 61be33b commit b71df80
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var AdManager = function (options) {
debug: false,
dfpId: 4246,
iasPubId: 927245,
iasEnabled: Feature.isOn('bulbs_ias'),
iasEnabled: true,
iasTimeout: 200,
amazonEnabled: true,
prebidEnabled: false,
Expand Down
12 changes: 7 additions & 5 deletions src/manager.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,16 @@ describe('AdManager', function() {
});

context('> base defaults', function() {
it('- no IAS support by default', function() {
expect(adManager.options.iasEnabled).to.be.false;
it('- IAS supported by default', function() {
expect(adManager.options.iasEnabled).to.be.true;
});
it('- reloads on resize', function() {
expect(adManager.options.doReloadOnResize).to.be.true;
});
});

context('> IAS enabled', function () {
context('> IAS functions correctly', function () {
var adManagerTestOptions = {
iasEnabled: true,
iasPubId: 123456,
dfpSiteCode: 'fmg.onion',
adUnits: adUnits
Expand All @@ -78,9 +77,11 @@ describe('AdManager', function() {
adManager = AdManagerWrapper.init({
doReloadOnResize: false,
dfpSiteCode: 'fmg.onion',
iasEnabled: false,
adUnits: adUnits
});
expect(adManager.options.doReloadOnResize).to.be.false;
expect(adManager.options.iasEnabled).to.be.false;
});
});

Expand Down Expand Up @@ -1540,7 +1541,8 @@ describe('AdManager', function() {

it('- calls googletag.pubads().refresh directly when no units are configured for prebid', function() {
TestHelper.stub(adManager.googletag, 'pubads').returns({
refresh: sinon.spy()
refresh: sinon.spy(),
getSlots: function() {return []}
});

adManager.refreshSlots([adSlot1]);
Expand Down

0 comments on commit b71df80

Please sign in to comment.