Skip to content

Conversation

@scezen
Copy link
Member

@scezen scezen commented Nov 12, 2025

JIRA: DERCBOT-1405

Back

  • New DialogWithNlpStats model wrapping DialogReport + List<NlpStats>
  • Updated /dialog/{applicationId}/{dialogId} endpoint to return NLP stats

Front

  • Added BotSharedService.getDialogWithNlpStats() to enrich actions with _nlpStats
  • Updated DialogComponent to use new service method
  • Pattern matches existing dialogs-list implementation

@scezen scezen marked this pull request as ready for review November 12, 2025 15:52
@vsct-jburet vsct-jburet self-requested a review November 20, 2025 15:38
@vsct-jburet
Copy link
Contributor

@scezen I have approved the PR, but you need to resolve the conflicts and sign the commit like this :

image

@vsct-jburet
Copy link
Contributor

I also assign to Copilot to test the feature ;)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds NLP statistics to the single dialog retrieval endpoint to match the existing dialogs-list pattern. The backend now returns a DialogWithNlpStats wrapper containing both the dialog and its associated NLP stats, while the frontend enriches action objects with _nlpStats data.

Key changes:

  • New backend model DialogWithNlpStats wrapping dialog and NLP stats
  • Updated /dialog/{applicationId}/{dialogId} endpoint to fetch and return NLP stats
  • Frontend service method getDialogWithNlpStats() parses response and enriches actions

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
bot/engine/src/main/kotlin/admin/dialog/DialogWithNlpStats.kt New data class combining DialogReport with List
bot/admin/server/src/main/kotlin/verticle/DialogVerticle.kt Updated single dialog endpoint to fetch NLP stats and return DialogWithNlpStats
bot/admin/web/src/app/shared/bot-shared.service.ts Added getDialogWithNlpStats() method to parse response and enrich actions with _nlpStats
bot/admin/web/src/app/analytics/dialog/dialog.component.ts Switched from analytics.dialog() to botSharedService.getDialogWithNlpStats()
shared/src/main/kotlin/vertx/WebVerticle.kt Added null-safety operator to context.session() call

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vsct-jburet
Copy link
Contributor

@scezen now you just have to squash the two commits and I merge ;)

image

@scezen
Copy link
Member Author

scezen commented Nov 21, 2025

@scezen now you just have to squash the two commits and I merge ;)

image

Can't seem to be able to squash both as the second one was resolved directly in Github UI. Locally I only have one commit... will check with @Benvii on monday.

Thanks for the review, really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants