-
Notifications
You must be signed in to change notification settings - Fork 154
[DERCBOT-1405] Add NlpStats to single dialog retrieval endpoint #1941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[DERCBOT-1405] Add NlpStats to single dialog retrieval endpoint #1941
Conversation
|
@scezen I have approved the PR, but you need to resolve the conflicts and sign the commit like this :
|
|
I also assign to Copilot to test the feature ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds NLP statistics to the single dialog retrieval endpoint to match the existing dialogs-list pattern. The backend now returns a DialogWithNlpStats wrapper containing both the dialog and its associated NLP stats, while the frontend enriches action objects with _nlpStats data.
Key changes:
- New backend model
DialogWithNlpStatswrapping dialog and NLP stats - Updated
/dialog/{applicationId}/{dialogId}endpoint to fetch and return NLP stats - Frontend service method
getDialogWithNlpStats()parses response and enriches actions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| bot/engine/src/main/kotlin/admin/dialog/DialogWithNlpStats.kt | New data class combining DialogReport with List |
| bot/admin/server/src/main/kotlin/verticle/DialogVerticle.kt | Updated single dialog endpoint to fetch NLP stats and return DialogWithNlpStats |
| bot/admin/web/src/app/shared/bot-shared.service.ts | Added getDialogWithNlpStats() method to parse response and enrich actions with _nlpStats |
| bot/admin/web/src/app/analytics/dialog/dialog.component.ts | Switched from analytics.dialog() to botSharedService.getDialogWithNlpStats() |
| shared/src/main/kotlin/vertx/WebVerticle.kt | Added null-safety operator to context.session() call |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@scezen now you just have to squash the two commits and I merge ;)
|



JIRA: DERCBOT-1405
Back
DialogWithNlpStatsmodel wrappingDialogReport+List<NlpStats>/dialog/{applicationId}/{dialogId}endpoint to return NLP statsFront
BotSharedService.getDialogWithNlpStats()to enrich actions with_nlpStatsDialogComponentto use new service methoddialogs-listimplementation