AsyncS3: throw FilesystemOperationFailed exceptions in case upload or listContent fails #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @glaubinix, could you convert the test from generated mocks to the S3ClientStub like the other tests? The rest looks like a nice contribution, much appreciated. |
… listContent fails
glaubinix
force-pushed
the
async-s3-exceptions
branch
from
98ec43f
to
67bfd18
Compare
|
Sure thing! Adjusted the test to match the other tests. |
|
Running the tests now :) will release when green |
|
Thank you! |
|
Out for a few, but will tag a release this afternoon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the async s3 adapter throws a
Symfony\Component\HttpClient\Exception\TransportExceptionin case a request fails. To match other adapters, this PR converts those exceptions toFilesystemOperationFailed.