ENH: Use exactextract by default for zonalstats calculation#181
Open
KriWay-LV wants to merge 32 commits intotheroggy:mainfrom
Open
ENH: Use exactextract by default for zonalstats calculation#181KriWay-LV wants to merge 32 commits intotheroggy:mainfrom
KriWay-LV wants to merge 32 commits intotheroggy:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 70.84% 71.30% +0.46%
==========================================
Files 37 38 +1
Lines 4863 4868 +5
==========================================
+ Hits 3445 3471 +26
+ Misses 1418 1397 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
theroggy
reviewed
May 12, 2025
Owner
theroggy
left a comment
There was a problem hiding this comment.
Already some first small remarks while waiting on the performance/result tests being done...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR changes the default for zonalstats calculation to "exactextract".
Exactextract has a lot more options regarding which (parts of) pixels are counted in the zonal statistics and which aren't. Based on some tests:
statsbeing calculated were changed to ???