Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow page allocation requests to specify a desired alignment #1029

Merged

Conversation

kevinaboos
Copy link
Member

The new AllocationRequest::AlignedAt variant can accept an alignment value, specified in number of 4K pages (not bytes).

This is needed to support easier allocation of huge pages, which have a large alignment requirement, e.g., 512 4K pages.
See #1016.

The new `AllocationRequest::AlignedAt` variant can accept an
alignment value, specified in number of 4K pages (not bytes).

This is needed to support easier allocation of huge pages,
which have a large alignment requiement, e.g., 512 4K pages.
@kevinaboos kevinaboos merged commit 4e54423 into theseus-os:theseus_main Aug 23, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 23, 2023
* The new `AllocationRequest::AlignedAt` variant can accept an
  alignment value, specified in number of 4K pages (not bytes).

* This is needed to support easier allocation of huge pages,
  which have a large alignment requirement, e.g., a 2MiB huge page
  requires a contiguous 512-page allocation aligned to that
  same boundary of 512 normal 4K pages (512 * 4KiB = 2MiB). 4e54423
tsoutsman pushed a commit to tsoutsman/Theseus that referenced this pull request Sep 6, 2023
…s-os#1029)

* The new `AllocationRequest::AlignedAt` variant can accept an
  alignment value, specified in number of 4K pages (not bytes).

* This is needed to support easier allocation of huge pages,
  which have a large alignment requirement, e.g., a 2MiB huge page
  requires a contiguous 512-page allocation aligned to that
  same boundary of 512 normal 4K pages (512 * 4KiB = 2MiB).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant