Change path to mimic std::path
#1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes `path` to export a `Path` and `PathBuf` struct, akin to `std::path`. Initially I made this change because it was necessary for Rust FFI for the `std` port, but it turns out the change also removed a lot of unnecessary allocations throughout the codebase. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
kevinaboos
requested changes
Oct 23, 2023
kevinaboos
approved these changes
Oct 24, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
* The `path` crate now exports a `Path` and `PathBuf` struct,
akin to `std::path`. This makes it easier to support `std`,
but also removes unnecessary allocations throughout Theseus.
* Notably, `Path::file_stem()` now returns an `Option<&str>`.
* This causes `crate_name_from_path()` to return a `Result`,
which is responsible for most of the logic changes required.
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com> 3fd2e4c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
pathto export aPathandPathBufstruct, akin tostd::path. Initially I made this change because it was necessary for Rust FFI for thestdport, but it turns out the change also removed a lot of unnecessary allocations throughout the codebase.Path::file_stem()to return anOption<&str>crate_name_from_path()to return a Result