Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify QEMU test workflow to ignore certain paths #1063

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

tsoutsman
Copy link
Member

The workflow won't run if the changes only include the following paths:

  • 'book/**'
  • 'c_test/**'
  • 'docker/**'
  • 'github_pages/**'
  • 'old_crates/**'
  • 'scripts/**'
  • '.gitignore'
  • 'LICENSE-MIT'
  • 'README.md'
  • 'bochsrc.txt'
  • 'rustfmt.toml'
  • 'slirp.conf'

I'd rather be conservative with the list of paths to exclude because if any of the paths inadvertently affect the CI run, that could lead to weird problems.

The workflow won't run if the changes only include the following paths:
- 'book/**'
- 'c_test/**'
- 'docker/**'
- 'github_pages/**'
- 'old_crates/**'
- 'scripts/**'
- '.gitignore'
- 'LICENSE-MIT'
- 'README.md'
- 'bochsrc.txt'
- 'rustfmt.toml'
- 'slirp.conf'

I'd rather be conservative with the list of paths to exclude because
if any of the paths inadvertently affect the CI run, that could lead to
weird problems.

Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Copy link
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather be conservative with the list of paths to exclude because if any of the paths inadvertently affect the CI run, that could lead to weird problems.

Fully agree. Thanks very much!

@kevinaboos kevinaboos merged commit c025bd1 into theseus-os:theseus_main Oct 24, 2023
3 checks passed
github-actions bot pushed a commit to Fortr4n/Theseus that referenced this pull request Oct 26, 2023
* The QEMU test workflow won't run if the changes only include:
- 'book/**'
- 'c_test/**'
- 'docker/**'
- 'github_pages/**'
- 'old_crates/**'
- 'scripts/**'
- '.gitignore'
- 'LICENSE-MIT'
- 'README.md'
- 'bochsrc.txt'
- 'rustfmt.toml'
- 'slirp.conf'

We specify ignore paths conservatively in order to avoid other paths
inadvertently affecting the CI action, which could lead to issues.

Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com> c025bd1
github-actions bot pushed a commit to tsoutsman/Theseus that referenced this pull request Oct 28, 2023
* The QEMU test workflow won't run if the changes only include:
- 'book/**'
- 'c_test/**'
- 'docker/**'
- 'github_pages/**'
- 'old_crates/**'
- 'scripts/**'
- '.gitignore'
- 'LICENSE-MIT'
- 'README.md'
- 'bochsrc.txt'
- 'rustfmt.toml'
- 'slirp.conf'

We specify ignore paths conservatively in order to avoid other paths
inadvertently affecting the CI action, which could lead to issues.

Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com> c025bd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants