Fix heap allocator bug
#1067
Merged
Fix heap allocator bug
#1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of `GlobalAlloc` for `Heap` assumed that all memory under `INITIAL_HEAP_END_ADDR` was allocated using the initial allocator, but this isn't true. `MultipleHeaps` allocates large objects using mapped pages leading to objects allocated in the lower half of memory. When deallocating these objects, `Heap` tried to deallocate them using the initial allocator rather than `MultipleHeaps`. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
kevinaboos
approved these changes
Oct 30, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
The implementation of `GlobalAlloc` for `Heap` assumed that all memory under `INITIAL_HEAP_END_ADDR` was allocated using the initial allocator, but this isn't true. `MultipleHeaps` allocates large objects using mapped pages leading to objects allocated in the lower half of memory. When deallocating these objects, `Heap` tried to deallocate them using the initial allocator rather than `MultipleHeaps`. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com> bafc2e8
github-actions bot
pushed a commit
to tsoutsman/Theseus
that referenced
this pull request
Oct 31, 2023
The implementation of `GlobalAlloc` for `Heap` assumed that all memory under `INITIAL_HEAP_END_ADDR` was allocated using the initial allocator, but this isn't true. `MultipleHeaps` allocates large objects using mapped pages leading to objects allocated in the lower half of memory. When deallocating these objects, `Heap` tried to deallocate them using the initial allocator rather than `MultipleHeaps`. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com> bafc2e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
GlobalAllocforHeapassumed that all memory underINITIAL_HEAP_END_ADDRwas allocated using the initial allocator, but this isn't true.MultipleHeapsallocates large objects using mapped pages leading to objects allocated in the lower half of memory. When deallocating these objects,Heaptried to deallocate them using the initial allocator rather thanMultipleHeaps.